k/replicated_partition: fixed fetch offset validation for follower fetching #16146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43880#018d1c17-5a86-446b-83d7-36c209f8567a ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43883#018d1cdd-3efb-43e4-b018-e6b09b8dc300 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43883#018d1cdd-3ef6-4b7f-8cc2-7efd5ce2d17a ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/43883#018d1ce3-1613-4c99-880d-04333e4ef970 |
|
Which all branches should this backport to @mmaslankaprv ? |
ztlpn
previously approved these changes
Jan 18, 2024
mmaslankaprv
force-pushed
the
fix-offset-validation
branch
2 times, most recently
from
3c69a7b
to
e4e3e57
Compare
…tching When consumer is requesting a fetch from the broker being a follower for given replica the fetch offset validation logic changes comparing to the validation on a leader. The out of range error should only be returned if an offset is not available locally and it is not known to be committed. That was not the case with the current code. The current code returned out of range error every time the offset was not committed on leader. This lead to many not necessary errors returned and resulted in consumer offsets being reset. Signed-off-by: Michal Maslanka <michal@redpanda.com>
mmaslankaprv
force-pushed
the
fix-offset-validation
branch
from
e4e3e57
to
fb48e0a
Compare
ztlpn
approved these changes
Jan 19, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When consumer is requesting a fetch from the broker being a follower for given replica the fetch offset validation logic changes comparing to the validation on a leader. The out of range error should only be returned if an offset is not available locally and it is not known to be committed. That was not the case with the current code. The current code returned out of range error every time the offset was not committed on leader. This lead to many not necessary errors returned and resulted in consumer offsets being reset.
Backports Required
Release Notes
Bug Fixes