[v23.3.x] k/replicated_partition: fixed fetch offset validation for follower fetching #16169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tching When consumer is requesting a fetch from the broker being a follower for given replica the fetch offset validation logic changes comparing to the validation on a leader. The out of range error should only be returned if an offset is not available locally and it is not known to be committed. That was not the case with the current code. The current code returned out of range error every time the offset was not committed on leader. This lead to many not necessary errors returned and resulted in consumer offsets being reset. Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit fb48e0a)
piyushredpanda
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16146