Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] audit: Reduce the number of memory allocations in the hotpath #16147

Merged
merged 8 commits into from
Jan 19, 2024
Merged

[v23.3.x] audit: Reduce the number of memory allocations in the hotpath #16147

merged 8 commits into from
Jan 19, 2024

Conversation

vbotbuildovich
Copy link
Collaborator

Backport of PR #16056

@graphcareful @vbotbuildovich
hashing: New utils for hashing multiple values
77c5083 
(cherry picked from commit a1b4ffb)
@graphcareful @vbotbuildovich
security: Make additional acl types hashable
608d2e2 
- That way auditing can hash these types to quickly get a hash code of a
larger ocsf type that encapsulates these acl options.

(cherry picked from commit 89564aa)
@graphcareful @vbotbuildovich
s/audit: Remove unused method declaration
79a3db0 
(cherry picked from commit 23628d0)
@graphcareful @vbotbuildovich
s/audit: Remove unused method
79a88bc 
(cherry picked from commit 01f32dd)
@graphcareful @vbotbuildovich
s/audit: New family of methods to hash audit types
6bff0f7 
(cherry picked from commit ef106e5)
@graphcareful @vbotbuildovich
s/audit: Move ocsf builders to static methods
4ee7774 
- This will be useful in future commits where a type can be passed to a
templated method and static polymorphic dispatch can be used to
determine which builder method to choose to construct the type

(cherry picked from commit f197cad)
@vbotbuildovich vbotbuildovich added this to the v23.3.x-next milestone Jan 18, 2024
@vbotbuildovich vbotbuildovich added the kind/backport PRs targeting a stable branch label Jan 18, 2024
@graphcareful graphcareful marked this pull request as ready for review January 18, 2024 14:38
@piyushredpanda piyushredpanda modified the milestones: v23.3.x-next, v23.3.3 Jan 19, 2024
@michael-redpanda
Copy link
Contributor

Force push d69f7f5:

  • Removed #include "base/vlog.h"

@BenPope
Copy link
Member

BenPope commented Jan 19, 2024

Force push d69f7f5:

  • Removed #include "base/vlog.h"

Shouldn't it be this?

#include "vlog.h"

@michael-redpanda
Copy link
Contributor

Force push d69f7f5:

  • Removed #include "base/vlog.h"

Shouldn't it be this?

#include "vlog.h"

Doesn't appear to be needed?

@michael-redpanda
Copy link
Contributor

CI Failures:

@piyushredpanda piyushredpanda merged commit e0c243a into redpanda-data:v23.3.x Jan 19, 2024
14 of 17 checks passed
@github-actions github-actions bot mentioned this pull request Jan 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphcareful graphcareful Awaiting requested review from graphcareful

Assignees
No one assigned
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Milestone
v23.3.3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vbotbuildovich @michael-redpanda @BenPope @piyushredpanda @graphcareful