[v23.2.x] metrics: fix kafka_max_offset on read replicas #16275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CONFLICT:
- cloud service implementation didn't exist in this version
Updates the filter used when collecting metrics samples.
In some cases, the samples take the form:
Sample(name='redpanda_kafka_max_offset', labels={'redpanda_namespace': 'kafka', 'redpanda_partition': '5', 'redpanda_topic': 'panda-topic'}, value=0.0, ...
(cherry picked from commit e567d63)
Read replicas were previously translating their own local log offsets to return `redpanda_kafka_max_offset` to the metrics endpoint. This is different from how read replicas calculate the HWM when returning to the Kafka endpoint, which just goes directly to cloud storage. This adds the same read replica check that we have in the Kafka layer. (cherry picked from commit 7e33cc7)
abhijat
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #16263
CONFLICT:
Fixes #16274
Backports Required
Release Notes
Bug Fixes
redpand_kafka_max_offsetmetric.