rpk: fix mixed use of backcompat flags with -X #16278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/dt |
|
new failures in https://buildkite.com/redpanda/redpanda/builds/44247#018d3db6-daf7-47b7-a362-1edf1f25f0e9: new failures in https://buildkite.com/redpanda/redpanda/builds/44247#018d3dc6-b87e-478d-9299-106f8bf35882: |
We were giving priority to old back compatibility flags (like --user, --password) over the new configuration (-X) flags. So if a user used both, the old ones got priority. This introduced a bug in rpk acl user create where we have a flag that collides with an old flag name: --password.
r-vasquez
force-pushed
the
prepend-flag-overrides
branch
from
ccadd4e
to
16835f6
Compare
|
/dt |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44259#018d3e8b-3c88-4e47-9d29-67508bff2d66 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/44259#018d4122-91b5-44c9-aaa9-89642a0bdc9d |
|
Unrelated error: https://buildkite.com/redpanda/redpanda/builds/44291#018d40e1-4549-41ce-b2d4-d91f0caed26a/6570-6895 Redpanda build timed out during RP unit test execution |
gene-redpanda
approved these changes
Jan 26, 2024
twmb
approved these changes
Jan 29, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Jan 29, 2024
|
Note: backport to v23.1.x is not needed since the issue doesn't exist in that version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were giving priority to old back compatibility
flags (like --user, --password) over the new
configuration (-X) flags. So if a user used both,
the old ones got priority.
This introduced a bug in rpk acl user create
where we have a flag that collides with an old
flag name: --password.
Fixes #16251
Backports Required
Release Notes
Bug Fixes
--passwordflag could not be used along with the new configuration flag-X passin clusters where basic authentication was enabled.