[v23.3.x] rpk: fix mixed use of backcompat flags with -X #16351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were giving priority to old back compatibility flags (like --user, --password) over the new configuration (-X) flags. So if a user used both, the old ones got priority. This introduced a bug in rpk acl user create where we have a flag that collides with an old flag name: --password. (cherry picked from commit 16835f6)
vbotbuildovich
requested review from
twmb,
r-vasquez and
gene-redpanda
as code owners
r-vasquez
approved these changes
Jan 29, 2024
|
Failure: https://buildkite.com/redpanda/redpanda/builds/44439#018d5648-501b-4e79-b931-224209cc9253/6-10041 Is #15949 which was fixed by #15981 but not yet backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16278
Fixes: #16350,