[v23.2.x] cloud_storage: Fix timequery bug that triggers full scan #16520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The remote_partition_reader can reset to the begining of the partition in case if it didn't find the segment and both config.start_offset and config.max_offset are outside of the manifest. When this logic is applied to the timequery in case if timestamp overshoots last segment in the manifest we end up having a full partition scan. This commit fixes this by disabling this logic for timequeries.
7 tasks
nvartolomei
approved these changes
Feb 7, 2024
|
/ci-repeat |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timequery can trigger full partition scan if the query overshoots the last segment. In this case if
log_reader_config.start_offsetis below the first segment in the manifest andlog_reader_config.max_offsetis above last offset in the manifest we will initialize the scan from the beginning which is very expensive.Fixes #16479 #16516
Backports Required
Release Notes
Bug Fixes