[v23.3.x] config: update bindings when properties are reset #16638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit bde7db0)
Previously, the max_connections_per_ip watch callback assumed that if there are overrides present, the main per-ip limit is there as well. (cherry picked from commit 30309ea)
Remove an old way of setting the property value that was only used in tests. (cherry picked from commit bb6e9b4)
Previously, if one of the binding watch callbacks threw an exception, the main property value didn't get updated, resulting in an inconsistency. (cherry picked from commit d58fe3d)
Previously we just set the value without notifying bindings. This lead to ignoring property value updates when the property was reset to its default value as a result of a patch_cluster_config request with non-empty "remove" section. (cherry picked from commit 7411586)
(cherry picked from commit 63eb446)
piyushredpanda
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16504