c/leaders: trigger leadership notification when term changes #16776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When term changes but leader stays on the same we should still trigger the leadership notification. Downstream components like `leadership_balancer` rely on this information to be triggered after successful leader election i.e. stable term change. Fixes: redpanda-data#16142 Signed-off-by: Michal Maslanka <michal@redpanda.com>
Leadership notification is triggered only on successful leader election. We do not need to pass the optional as `leader_id` is always present. Signed-off-by: Michal Maslanka <michal@redpanda.com>
Under which scenarios does that happen? When we vote but the current leader wins the election? |
it may happen when leadership transfer to desired node fails f.e. transfer request from 2->1 fails and 2 is elected as the leader once again |
|
I see, so it should still be relatively rare. |
StephanDollberg
approved these changes
Feb 28, 2024
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45457#018df105-b431-41cc-9723-5da0fba0fb3c |
bharathv
approved these changes
Feb 28, 2024
|
/backport v23.3.x |
|
/backport v23.2.x |
|
Failed to create a backport PR to v23.2.x branch. I tried: |
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When term changes but leader stays on the same we should still trigger the leadership notification.
Downstream components like
leadership_balancerrely on this information to be triggered after successful leader election i.e. stable term change.Fixes: #16142
Backports Required
Release Notes