[v23.3.x] Improve throughput throttling #16848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenPope
force-pushed
the
backport-16441-v23.3.x
branch
2 times, most recently
from
0edfbe5
to
d628e41
Compare
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit bd42479) Conflicts: src/v/ssx/sharded_ptr.h (header include) src/v/ssx/tests/sharded_ptr_test.cc (includes)
Refactor only, no functional change. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 20ca50a)
New metrics: * `traffic_egress` - mirrors `traffic_intake` * `throttle_time` - Histogram of throttle time requested Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 679804c)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 55d8952)
When `kafka_throughput_throttling_v2` is enabled (true by default), use an `ss::internal::shared_token_bucket` for requests across all shards, instead of balancing quota between shards. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 6ddfb32) Conflicts: src/v/kafka/server/snc_quota_manager.h (header include)
BenPope
force-pushed
the
backport-16441-v23.3.x
branch
from
d628e41
to
1dee3d6
Compare
michael-redpanda
previously approved these changes
Mar 8, 2024
michael-redpanda
dismissed
their stale review
Dismissing review to wait for testing, but I'm good with this
michael-redpanda
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16441
Fixes: #16815