k/group_manager: used chunked_vector when cleaning groups #16920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumer groups are removed when a topic that they are related with is removed from topics table. Previously the code cleaning up consumer groups was using a plain `std::vector` to store deltas coming from the `cluster::topics_table` notification. That lead to large allocation. Replaced the `std::vector` with chunked vector to make allocation size controlled. Fixes: redpanda-data#15946 Signed-off-by: Michal Maslanka <michal@redpanda.com>
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45752#018e1568-d1b5-4182-b162-ba8f785ec712 |
StephanDollberg
approved these changes
Mar 7, 2024
|
/backport v23.3.x |
This was referenced Apr 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer groups are removed when a topic that they are related with is removed from topics table. Previously the code cleaning up consumer groups was using a plain
std::vectorto store deltas coming from thecluster::topics_tablenotification. That lead to large allocation. Replaced thestd::vectorwith chunked vector to make allocation size controlled.Fixes: #15946
Backports Required
Release Notes