[v23.3.x] k/group_manager: used chunked_vector when cleaning groups #17584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmaslankaprv
approved these changes
Apr 3, 2024
Consumer groups are removed when a topic that they are related with is removed from topics table. Previously the code cleaning up consumer groups was using a plain `std::vector` to store deltas coming from the `cluster::topics_table` notification. That lead to large allocation. Replaced the `std::vector` with chunked vector to make allocation size controlled. Fixes: redpanda-data#15946 Signed-off-by: Michal Maslanka <michal@redpanda.com> (cherry picked from commit 2e2f7eb)
mmaslankaprv
force-pushed
the
backport-pr-16920-v23.3.x-510
branch
from
bf647d6
to
b53a6e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #16920
Fixes: #17583,