Add an option to specify topic name for nodes_report_cloud_segments #16925
Conversation
|
|
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/45767#018e168d-2180-40c4-837b-5420135f4ad1 |
|
Buildkite shows as passed: But when I clicked on details, I see that 1 test actually failed: Also, I already signed the license and got redirected to GH. If I click details and try to sign again, it says I already signed it. But for some reason this check is still pending even if I click "recheck" |
|
OK, looks like I had different name and email set in local Git.. Updated it globally and would need to fix this tomorrow so license check would pass |
Yes, I will remove it. It would be used in another task and also we might host it somewhere else and avoid committing due to file size. Thanks for pointing this out. |
rpdevmp
force-pushed
the
rpdevmp/iptables-989
branch
from
a355b6d
to
e985384
Compare
rpdevmp
force-pushed
the
rpdevmp/iptables-989
branch
from
e985384
to
c4dae02
Compare
| self.logger.info(f"Getting the first 100 segments into the cloud") | ||
| wait_until(lambda: nodes_report_cloud_segments(self.redpanda, 100), | ||
| self.logger.info( | ||
| f"Getting the first 100 segments into the cloud for specific topic" |
There was a problem hiding this comment.
this f-string doesn't contain any interpolated values. did you intend to add some extra context to it?
There was a problem hiding this comment.
Good catch, it was like this before, I just modified it a bit. For now should be good
|
Forced: due to ghost bk-redpanda issue. |
Backports Required
Improvements
Improvements to internal high thougput tests to be able to specify and count topic-specific segments
Release Notes
This is internal testing HTT and release notes not required.
NOTE: This has NOT been tested locally yet. I would need to pull this code to my AWS EC2 instance and test it. Submitting PR for initial discussion and comments