schema_registry: Override soft-delete checks for consume_to_store #17091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that a soft-delete can be compacted away in a different segment to the hard delete. After compaction the topic is still correct and the commands should always be applied to the store. Override the soft-delete check if the command comes from the topic rather than the REST API. Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
force-pushed
the
schema_registry_compaction_override
branch
from
9c078d2
to
bf1c314
Compare
|
new failures in https://buildkite.com/redpanda/redpanda/builds/46180#018e3d4d-db51-494a-87f0-9f7e09ed9c24: |
|
Failure is unrelated and looks like #9315 |
|
/backport v23.3.x |
|
/backport v23.2.x |
This was referenced Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that a soft-delete can be compacted away in a different segment to the hard delete. After compaction the topic is still correct and the commands should always be applied to the store.
Override the soft-delete check if the command comes from the topic rather than the REST API.
Fixes https://github.com/redpanda-data/core-internal/issues/1089
Backports Required
Release Notes
Bug Fixes
_schemastopic.