[v23.3.x] schema_registry: Override soft-delete checks for consume_to_store #17094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's possible that a soft-delete can be compacted away in a different segment to the hard delete. After compaction the topic is still correct and the commands should always be applied to the store. Override the soft-delete check if the command comes from the topic rather than the REST API. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit bf1c314)
|
CI Issue: #14139 |
michael-redpanda
merged commit 1ac6597
into
redpanda-data:v23.3.x
14 of 17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17091