wasm/wasi: properly return number of written bytes #17186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
oleiman
approved these changes
Mar 19, 2024
|
Yes, I am going to introduce a test that prints things in |
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46445#018e5819-158c-4a76-8e5a-326852b774c8 ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/46445#018e5819-158f-4293-bb0d-98eb75ce3db3 |
|
/backport v23.3.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When simplifying updating the wasi logging code, we missed setting the number of written bytes.
Fix that so that write doesn't continue to try to write in a loop.
I will followup with some tests here, but wanted to get this out.
Backports Required
Release Notes
Bug Fixes