Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasm: logging tests #17208

Merged
merged 4 commits into from
Mar 21, 2024
Merged

wasm: logging tests #17208

merged 4 commits into from
Mar 21, 2024

Conversation

rockwotj
Copy link
Contributor

Followup to #17186

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@rockwotj rockwotj requested a review from a team as a code owner March 20, 2024 03:10
@rockwotj rockwotj requested review from ivotron and removed request for a team March 20, 2024 03:10
@rockwotj rockwotj self-assigned this Mar 20, 2024
@rockwotj rockwotj requested a review from oleiman March 20, 2024 03:14
@rockwotj rockwotj changed the title Logging tests wasm: logging tests Mar 20, 2024
@vbotbuildovich
Copy link
Collaborator

vbotbuildovich commented Mar 20, 2024

new failures in https://buildkite.com/redpanda/redpanda/builds/46478#018e5a1a-57a3-48a8-8497-578010266b47:

"rptest.tests.offset_for_leader_epoch_archival_test.OffsetForLeaderEpochArchivalTest.test_querying_remote_partitions.remote_reads=.False.True"

new failures in https://buildkite.com/redpanda/redpanda/builds/46515#018e62e4-3168-4ec5-b597-c4959b1b7023:

"rptest.tests.topic_creation_test.CreateTopicsResponseTest.test_create_topic_response_configs"

oleiman
oleiman previously approved these changes Mar 20, 2024
Copy link
Member

@oleiman oleiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

ss::sstring expected;
// NOLINTNEXTLINE(*-reinterpret-cast)
expected.append(reinterpret_cast<const char*>(bytes.data()), bytes.size());
EXPECT_THAT(log_lines(), ElementsAre(expected));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slick

src/transform-sdk/rust/examples/identity_logging.rs Outdated Show resolved Hide resolved
Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Capture logs in the test fixture so we can assert the correct behavior
in the transform code.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
This test ensures that we properly implement wasi's fd_write method

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
Add e2e tests for each language that logging works as expected.

Note that in Rust if we don't buffer everything Rust's library will call
write(2) multiple times.

Signed-off-by: Tyler Rockwood <rockwood@redpanda.com>
@rockwotj
Copy link
Contributor Author

/ci-repeat

@rockwotj rockwotj merged commit 6ce62bf into redpanda-data:dev Mar 21, 2024
20 of 23 checks passed
@rockwotj rockwotj deleted the logging-tests branch March 21, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants