goreleaser: adjust goreleaser to dynamically link rpk on linux #17230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewhsu
changed the title
andrewhsu
force-pushed
the
PESDLC-1005-dyn-compile-rpk
branch
2 times, most recently
from
1d1f529
to
66e3b6b
Compare
|
/dt |
andrewhsu
force-pushed
the
PESDLC-1005-dyn-compile-rpk
branch
4 times, most recently
from
dcd7a4c
to
8b8ece5
Compare
andrewhsu
force-pushed
the
PESDLC-1005-dyn-compile-rpk
branch
from
8b8ece5
to
032a923
Compare
andrewhsu
changed the title
|
this is ready for review |
twmb
reviewed
Mar 28, 2024
|
Wait does this mean an RP release will now have two versions of rpk in one zip file? |
@twmb there will still be 1 zip file per |
ivotron
previously approved these changes
Mar 29, 2024
|
i added git commit so this one can be merged safely by itself. ready for re-review. cc @ivotron |
Removal of rpk-windows-and-linux will happen in future after vtools references to it are pointing to alternative ids.
andrewhsu
force-pushed
the
PESDLC-1005-dyn-compile-rpk
branch
from
f2772f9
to
e6e39e7
Compare
ivotron
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://redpandadata.atlassian.net/browse/PESDLC-1005
add goreleaser build id
rpk-linux-microsoft-gofor use with microsoft's golang compiler. this configures the compiler to dynamically linkrpkfor deb/rpm packages.the
zipfiles ofrpkgenerated by goreleaser that are attached as assets to redpanda github releases are left as statically compiled.this PR needs to be merged in sync with PR https://github.com/redpanda-data/vtools/pull/2588EDIT: i added git commit e6e39e7 so existing vtools can work without changes
Backports Required
Release Notes