s3_client: add keys to log messages #17666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47420#018eabaa-7cb2-4ebd-9f72-d52a0751b62d ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47590#018ec6ba-4b04-42a8-84b2-af2d180a580e |
dotnwat
previously approved these changes
Apr 6, 2024
andrwng
force-pushed
the
s3-client-log-keys
branch
from
b78e186
to
5125328
Compare
dotnwat
previously approved these changes
Apr 9, 2024
andrwng
force-pushed
the
s3-client-log-keys
branch
from
5125328
to
d156556
Compare
|
Pushed a new fix for the test |
An upcoming commit will log the key on error in the s3 client. As is, delete_objects() would pass in a dummy key to be logged, whose lifetime would not last to logging time. This commit makes the method co_await to ensure the variable lasts for the duration of the call.
I noticed in some clusters that some NotFound errors show up a lot, and it's hard to tell whether they're alarming or not without more context. ``` 2024-04-04 23:15:41,069 [shard 0:au ] s3 - s3_client.cc:866 - S3 DeleteObject request failed: Not Found [X-GUploader-UploadID: ABPtcPo1Yr9tl-T0lj12Bu-qfbQN8GJVz9KSjvNVfHQef8LQmrwLIoGBvteJdNLTQRqrE0fbVcA];[Content-Type: application/xml; charset=UTF-8];[Content-Length: 289];[Vary: Origin];[Date: Thu, 04 Apr 2024 23:15:41 GMT];[Expires: Thu, 04 Apr 2024 23:15:41 GMT];[Cache-Control: private, max-age=0];[Server: UploadServer];", ``` This commit adds the object key to several existing (mostly) warn and error level logs.
andrwng
force-pushed
the
s3-client-log-keys
branch
from
d156556
to
6465d92
Compare
|
Per discussion with Noah, changed approaches to co_await instead of using a static variable. |
dotnwat
approved these changes
Apr 10, 2024
nvartolomei
added a commit
to nvartolomei/redpanda
that referenced
this pull request
Apr 15, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in some clusters that some NotFound errors show up a lot, and it's hard to tell whether they're alarming or not without more context.
This commit adds the object key to several existing (mostly) warn and error level logs.
Backports Required
Release Notes