Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-2348 s3_client: fix typo in log statement format specifier #17868

Merged
merged 1 commit into from
Apr 15, 2024
Merged

CORE-2348 s3_client: fix typo in log statement format specifier #17868

merged 1 commit into from
Apr 15, 2024

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Apr 15, 2024 •
edited

Introduced in #17666 Fixes #17862

Also,
Fixes #17842
Fixes #17858
Fixes #17849
Fixes #17843

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

andijcr
andijcr approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@andijcr andijcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm we really need to push a bit of compile time checks into the logging wrappers

dotnwat
dotnwat approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@dotnwat dotnwat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vbotbuildovich
Copy link
Collaborator

new failures in https://buildkite.com/redpanda/redpanda/builds/47813#018ee325-c8c0-4a09-8cd6-6d377cc0ca1d:

"rptest.tests.write_caching_fi_test.WriteCachingFailureInjectionTest.test_unavoidable_data_loss"

@vbotbuildovich
Copy link
Collaborator

ducktape was retried in https://buildkite.com/redpanda/redpanda/builds/47813#018ee34e-ada2-4dd8-a888-d57e8a3608f9

@dotnwat
Copy link
Member

dotnwat commented Apr 15, 2024

oversized allocation and cluster_health_monitor_test_rpfixture failure.

@dotnwat dotnwat merged commit 3ed09f5 into redpanda-data:dev Apr 15, 2024
15 of 19 checks passed
@dotnwat dotnwat mentioned this pull request Apr 17, 2024
Closed
@dotnwat dotnwat changed the title s3_client: fix typo in log statement format specifier CORE-2348 s3_client: fix typo in log statement format specifier Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnwat dotnwat dotnwat approved these changes

@andijcr andijcr andijcr approved these changes

Assignees
No one assigned
Labels
area/redpanda
Projects
None yet
Milestone
No milestone
4 participants
@nvartolomei @vbotbuildovich @dotnwat @andijcr