-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rptest: write caching tests with failure injection #17671
rptest: write caching tests with failure injection #17671
Conversation
This still a draft? |
@bharathv need to merge the other PR first otherwise this fails |
b705493
to
434c2f8
Compare
434c2f8
to
75ffe7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice tests, lgtm, couple of questions.
total_produced += num_msg_per_round | ||
|
||
@cluster(num_nodes=4) | ||
def test_crash_all(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think this is same as the test in the other PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is pretty much the same but this one doesn't have a dependency of the correctly implemented consumer. This is much easier to debug and work with.
I'd prefer to keep both.
valid_reads), "unexpected number of consumed messages" | ||
|
||
@cluster(num_nodes=4) | ||
def test_leader_epoch(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you already added a similar test in unit tests,, wondering if we need this (in the spirit of reducing test runtime).. I don't mind keeping it, just asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are similar in the expectations but the behavior is different enough to have a separate test. This one asserts the behavior during data-loss scenario thus exercising more than just kafka layer.
Depends on #17674
Backports Required
Release Notes