Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rptest: write caching tests with failure injection #17671

Merged

Conversation

nvartolomei
Copy link
Contributor

@nvartolomei nvartolomei commented Apr 5, 2024

Depends on #17674

Backports Required

  • none - not a bug fix
  • none - this is a backport
  • none - issue does not exist in previous branches
  • none - papercut/not impactful enough to backport
  • v23.3.x
  • v23.2.x

Release Notes

  • none

@bharathv
Copy link
Contributor

bharathv commented Apr 5, 2024

This still a draft?

@nvartolomei
Copy link
Contributor Author

@bharathv need to merge the other PR first otherwise this fails

@nvartolomei nvartolomei force-pushed the nv/low-level-write-caching-test branch 3 times, most recently from b705493 to 434c2f8 Compare April 8, 2024 13:09
@nvartolomei nvartolomei force-pushed the nv/low-level-write-caching-test branch from 434c2f8 to 75ffe7b Compare April 10, 2024 15:25
@nvartolomei nvartolomei marked this pull request as ready for review April 10, 2024 15:34
Copy link
Contributor

@bharathv bharathv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tests, lgtm, couple of questions.

total_produced += num_msg_per_round

@cluster(num_nodes=4)
def test_crash_all(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think this is same as the test in the other PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is pretty much the same but this one doesn't have a dependency of the correctly implemented consumer. This is much easier to debug and work with.

I'd prefer to keep both.

valid_reads), "unexpected number of consumed messages"

@cluster(num_nodes=4)
def test_leader_epoch(self):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you already added a similar test in unit tests,, wondering if we need this (in the spirit of reducing test runtime).. I don't mind keeping it, just asking.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are similar in the expectations but the behavior is different enough to have a separate test. This one asserts the behavior during data-loss scenario thus exercising more than just kafka layer.

@bharathv bharathv merged commit 6935640 into redpanda-data:dev Apr 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants