Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v23.2.x] c/controller_backend: try to force-abort reconfiguration only on leaders #18044

Merged
merged 1 commit into from
May 14, 2024

Conversation

ztlpn
Copy link
Contributor

@ztlpn ztlpn commented Apr 24, 2024

Backport of PR #18021

Fixes #18040

Previously, when force-aborting a reconfiguration, we appended an
aborting configuration on all replicas. This can lead to log inconsistencies
as on followers the configuration will be duplicated (one from own append,
one replicated by the leader). Although these inconsistencies are
expected for force-abort, if the leader is alive, we can minimize the chance
of their appearance by waiting on followers for the aborting config to be
replicated from the leader.

Fixes redpanda-data#17847

(cherry picked from commit 8e221d3)
@ztlpn ztlpn added this to the v23.2.x-next milestone Apr 24, 2024
@ztlpn ztlpn added the kind/backport PRs targeting a stable branch label Apr 24, 2024
@ztlpn ztlpn marked this pull request as ready for review April 24, 2024 10:56
@ztlpn
Copy link
Contributor Author

ztlpn commented May 14, 2024

Failure is #10140

@ztlpn ztlpn merged commit 0945c56 into redpanda-data:v23.2.x May 14, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/redpanda kind/backport PRs targeting a stable branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[v23.2.x] c/controller_backend: try to force-abort reconfiguration only on leaders
2 participants