[v23.3.x] [CORE-2399] Schema Registry: Improve retries and tombstoning #18624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 23c12f5)
* Remove unusual "this" parameter Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 60ceea9)
* Remove unused params Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit a2c9a16)
* Factor out seq_marker construction into batch_builder
* Simplify consume_to_store by reusing the batch
* This is slightly more work, due to decoding, but
means a consistent code path is taken.
* Refactor all writes through produce_and_apply
Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit ae8f74a)
Conflicts:
src/v/pandaproxy/schema_registry/seq_writer.cc (includes)
Add retry logic for: * delete_config * delete_subject_permanent Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 640cb84)
Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 813c4be)
When permanantly deleting a subject, delete the subject version, even if it's the last one. Signed-off-by: Ben Pope <ben@redpanda.com> (cherry picked from commit 6a48b96)
Signed-off-by: Ben Pope <ben@redpanda.com>
Signed-off-by: Ben Pope <ben@redpanda.com>
BenPope
requested review from
graphcareful and
a team
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #17905
Fixes #17951
Manual, because there was a small header include conflict in seq_writer.
I also grabbed a couple of small followup fixes from #17952