Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v23.3.x] [CORE-2399] Schema Registry: Improve retries and tombstoning #18624

Merged
merged 9 commits into from
May 22, 2024
Merged

[v23.3.x] [CORE-2399] Schema Registry: Improve retries and tombstoning #18624

merged 9 commits into from
May 22, 2024

Commits on May 22, 2024

  1. schema_registry: Tidy up swagger for config 

    Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit 23c12f5)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    bc16a7d View commit details
    Browse the repository at this point in the history

  2. schema_registry: Refactor seq_writer 

    * Remove unusual "this" parameter

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit 60ceea9)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    0f93e1e View commit details
    Browse the repository at this point in the history

  3. schema_registry: Refactor seq_writer 

    * Remove unused params

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit a2c9a16)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ce69e7f View commit details
    Browse the repository at this point in the history

  4. schema_registry: Refactor seq_writer 

    * Factor out seq_marker construction into batch_builder
* Simplify consume_to_store by reusing the batch
  * This is slightly more work, due to decoding, but
    means a consistent code path is taken.
* Refactor all writes through produce_and_apply

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit ae8f74a)

Conflicts:
    src/v/pandaproxy/schema_registry/seq_writer.cc (includes)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    6926edf View commit details
    Browse the repository at this point in the history

  5. schema_registry: Improve seq_writer retry logic 

    Add retry logic for:
* delete_config
* delete_subject_permanent

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit 640cb84)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8ae5b6d View commit details
    Browse the repository at this point in the history

  6. schema_registry: Remove config when soft deleting subject 

    Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit 813c4be)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    b619d76 View commit details
    Browse the repository at this point in the history

  7. schema_registry: Remove subject versions when removing subject 

    When permanantly deleting a subject, delete the subject version,
even if it's the last one.

Signed-off-by: Ben Pope <ben@redpanda.com>
(cherry picked from commit 6a48b96)
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    5a5e2ff View commit details
    Browse the repository at this point in the history

  8. schema_registry/seq_writer: Avoid unhandled exception 

    Signed-off-by: Ben Pope <ben@redpanda.com>
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    20280a9 View commit details
    Browse the repository at this point in the history

  9. schema_registry/swagger: Fix typo 

    Signed-off-by: Ben Pope <ben@redpanda.com>
    @BenPope
    BenPope committed May 22, 2024
    Configuration menu
    Copy the full SHA
    f5c69d5 View commit details
    Browse the repository at this point in the history