Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction visibility problem #3036

Merged
merged 3 commits into from Nov 20, 2021
Merged

Fix transaction visibility problem #3036

merged 3 commits into from Nov 20, 2021

Commits on Nov 20, 2021

  1. kafka/tx: fix tx visibility problem 

    We control visibility of the transactions by using last_stable_offset()
to set the maximum offset a reader may consume. See make_reader and
log_reader_config::max_offset.

Because last_stable_offset() returns supremum of the consumable offsets
and make_reader expects maximum it led to an off by one error and made
records of the aborted transactions visible.

Fixing the issue by converting supremum to maximum.

Fixes https://github.com/vectorizedio/support/issues/176
    @rystsov
    rystsov committed Nov 20, 2021
    Copy the full SHA
    4980311 View commit details
    Browse the repository at this point in the history

  2. ducky: update java client version

    @rystsov
    rystsov committed Nov 20, 2021
    Copy the full SHA
    52a7973 View commit details
    Browse the repository at this point in the history

  3. ducky: add concurrent tx reads/writes test 

    Adding a ducktape test to prevent regression in the future
    @rystsov
    rystsov committed Nov 20, 2021
    Copy the full SHA
    dba62b1 View commit details
    Browse the repository at this point in the history