Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ–₯️ Explicitly display the severity instead of using only colors #85

Closed
favonia opened this issue Oct 7, 2023 · 2 comments Β· Fixed by #93
Closed

πŸ–₯️ Explicitly display the severity instead of using only colors #85

favonia opened this issue Oct 7, 2023 · 2 comments Β· Fixed by #93
Labels
enhancement New feature or request tty
Milestone

Comments

@favonia
Copy link
Contributor

favonia commented Oct 7, 2023

The Tty backend should have explicitly printed out the severity (e.g., "ERROR") instead of only relying on highlighting colors. This was suggested by @mikeshulman and I strongly agreed! I guess the remaining question is to find a good place in the Unicode art to add it:

Current output with location information:

    ╒══ examples/stlc/example.lambda
    β”‚
  1 β”‚ line1
  2 β”‚ line2
    β”Š
 20 β”‚ line20
 21 β”‚ line21
    β”·
 [E002] Message line 1
        Message line 2

Current output without location information:

 [E002] Message line 1
        Message line 2
@favonia favonia added enhancement New feature or request tty labels Oct 7, 2023
@favonia favonia added this to the 0.2.0 milestone Oct 7, 2023
@favonia
Copy link
Contributor Author

favonia commented Oct 8, 2023

Actually, this is worse than I thought, because severity was not indicated at all when there's no location information.

@mikeshulman
Copy link
Collaborator

Maybe that explains why I wasn't seeing the colors either, because I don't have any location info yet.

@favonia favonia mentioned this issue Oct 8, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tty
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants