Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include tests for Counter as example? #21

Closed
mii9000 opened this issue Apr 15, 2020 · 4 comments
Closed

Include tests for Counter as example? #21

mii9000 opened this issue Apr 15, 2020 · 4 comments

Comments

@mii9000
Copy link

mii9000 commented Apr 15, 2020

No description provided.

@nickserv nickserv mentioned this issue Apr 18, 2020
Closed
@nickserv
Copy link
Contributor

This is a good idea, but let's start it on cra-template-redux and then port it here with types: reduxjs/cra-template-redux#23

@markerikson
Copy link
Contributor

Fixed by #32, mostly, and I'll do some more tweaks.

@markerikson
Copy link
Contributor

I take that back. #32 was just the slice. We could still use some tests for the Counter component, but I don't feel like writing them atm.

@markerikson markerikson reopened this Apr 5, 2021
@Mokshit06 Mokshit06 mentioned this issue Apr 15, 2021
Closed
@markerikson
Copy link
Contributor

Superseded by #90 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for Counter and update dependencies
3 participants
@nickserv @markerikson @mii9000