fix: abort controller fallback

[JulienKode]

Description

Inside createAsyncThunk currently RTK have a fallback in case AbortController is not declared.

redux-toolkit/packages/toolkit/src/createAsyncThunk.ts

Line 530 in e307245

typeof AbortController !== 'undefined'

This seems not the case for the listenerMiddleware

redux-toolkit/packages/toolkit/src/listenerMiddleware/index.ts

Line 89 in 3d7bd22

const childAbortController = new AbortController()

How to reproduce the issue ?

• Create a next.js project with node 14
• use listener middleware on server side
• see the reference error of AbortController

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 242d99f:

Sandbox	Source
Vanilla	Configuration
Vanilla Typescript	Configuration
rsk-github-issues-example	Configuration
@examples-query-react/basic	Configuration
@examples-query-react/advanced	Configuration
reduxjs/redux-toolkit	Configuration

[netlify]

✅ Deploy Preview for redux-starter-kit-docs ready!

Name	Link
🔨 Latest commit	242d99f
🔍 Latest deploy log	https://app.netlify.com/sites/redux-starter-kit-docs/deploys/62b4bbb4a1abe70008b738b2
😎 Deploy Preview	https://deploy-preview-2446--redux-starter-kit-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[phryneas]

Hi, thanks for the PR!

At this point I am thinking we should rather remove that polyfill: IE has dropped and there is no more desktop browser supporting it. In node environments, that polyfill can cause more harm than good, since some fetch polyfills only work with very specific AbortController polyfills.

So my suggestion would be that we keep it for the time being and remove that polyfill in the 2.0 major. @markerikson what are your thoughts?

[JulienKode]

Hi @phryneas

Thanks for your feedback on this,
Seems a good idea

What will be the plan for the v2, should AbortController be mandatory to use RTK ?

[phryneas]

I haven't thought about it in-depth, but given that you don't need a polyfill in the browser any more, node 16 ships with AbortController, and (in the case of older node versions) on the server installing a polyfill also doesn't consume any "over the wire data", I think it would be okay to say "we expect an AbortController implementation to be available".

[JulienKode]

This makes sense, in the same way as fetch

[JulienKode]

Should I close this PR or it's still relevant for pre 2.0 version ?

[phryneas]

Good question - could you close this, but open an issue in the other direction a la "remove abortcontroller" so we can label that as 2.0 and track it? :)

[JulienKode]

Thanks I've created #2448