Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better generic argument for default Thunk Middleware #329

Merged
merged 5 commits into from Feb 9, 2020

Conversation

phryneas
Copy link
Member

This should fix #321

@netlify
Copy link

netlify bot commented Jan 24, 2020

Deploy preview for redux-starter-kit-docs ready!

Built with commit 958a09a

https://deploy-preview-329--redux-starter-kit-docs.netlify.com

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 958a09a:

Sandbox Source
exciting-tdd-98m19 Configuration
elated-northcutt-ezzek Configuration
rsk-github-issues-example Configuration

@markerikson
Copy link
Collaborator

As usual, I don't know enough to say if this is actually an improvement or not, so I'll go with your expertise here :)

Two additional things that would potentially need to be updated accordingly:

  • The Redux core "Usage with TS" page
  • The RTK "Advanced Tutorial" example repo. This one's more complicated, unfortunately, because the repo and the sandboxes based on a specific commit history. We'd really need to go rewrite the commit history with this one change. I've done that a few times already, but it's a pain.

@phryneas
Copy link
Member Author

phryneas commented Feb 9, 2020

Okay, should now work with null, undefined and unknown in the AppThunk parameter. As for documentation updates, I guess I have covered everything in various PRs.

See #348 and reduxjs/redux#3693

@markerikson markerikson merged commit feaf9ac into reduxjs:master Feb 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

store.dispatch does not work in 1.2.2
2 participants