Docs update: recommend unknown instead of null as ThunkAction extraArgument type
#3693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
changed the title
unknown instead of null as ThunkAction extraArgument typeunknown instead of null as ThunkAction extraArgument type
|
Deploy preview for redux-docs ready! Built with commit cea0a8d |
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…pe (reduxjs#3693) Former-commit-id: 8e59650 Former-commit-id: b0c366d
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…pe (reduxjs#3693) Former-commit-id: 8e59650 Former-commit-id: b0c366d
webMasterMrBin
pushed a commit
to webMasterMrBin/redux
that referenced
this pull request
Aug 21, 2021
…pe (reduxjs#3693) Former-commit-id: 8e59650 Former-commit-id: b0c366d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the docs suggest
nullas type for theextraArgumentgeneric argument ofThunkAction.This only works if the
ThunkMiddlewareis invoked withnullasextraArgumentas well. The default value forThunkMiddlewareisunknownthough, making these thunks incompatible with the default-typedThunkMiddleware.This change suggests to use
unknowninstead, which would work with Middlewares typed for any type ofextraArgument.