Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle binaryTargets differently in the Tutorial #278

Closed
thedavidprice opened this issue Mar 17, 2020 · 3 comments
Closed

Handle binaryTargets differently in the Tutorial #278

thedavidprice opened this issue Mar 17, 2020 · 3 comments
Labels
bug/confirmed We have confirmed this is a bug topic/crwa create-redwood-app topic/prisma

Comments

@thedavidprice
Copy link
Contributor

@peterp @cannikin

See Peter's suggestion here #270

Maybe a short term solution is to remove the binary targets line in the prisma configuration, and then suggest that people change it to binaryTargets = ["native", "rhel-openssl-1.0.x"] when they want to deploy to Netlify?

Also another Windows specific issue+solution here #215

Nevermind - I just realized I needed to update the binaryTargets in the schema.prisma file from binaryTargets = ["native", "rhel-openssl-1.0.x"] to binaryTargets = ["native", "windows”]

Piecing these together for possible next steps:

  1. remove binaryTargets = ["native", "rhel-openssl-1.0.x”] from create-redwood-app default schema.prisma
  2. add instructions to Tutorial deploy section about setting binaryTargets
  3. need different settings for Mac and Windows

Does this seem correct?

@thedavidprice thedavidprice added kind/bug topic/prisma bug/confirmed We have confirmed this is a bug topic/crwa create-redwood-app labels Mar 17, 2020
@cannikin
Copy link
Member

Yep that sounds correct. I can add that line to the tutorial after lunch!

@cannikin
Copy link
Member

It seems like this will end up being the same issue as the provider—this needs to be IN the code so that a deployment to Netlify can work. However when you're in local dev you'll need to remove again to keep working?

@peterp
Copy link
Contributor

peterp commented Mar 18, 2020

Closed by redwoodjs/create-redwood-app#38

@peterp peterp closed this as completed Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/crwa create-redwood-app topic/prisma
Projects
None yet
Development

No branches or pull requests

3 participants