Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] yarn rw dev fails when path includes a space or special characters #409

Closed
thedavidprice opened this issue Apr 9, 2020 · 2 comments
Labels
bug/confirmed We have confirmed this is a bug topic/cli topic/windows

Comments

@thedavidprice
Copy link
Contributor

thedavidprice commented Apr 9, 2020

Windows: v10
Powershell
@redwoodjs: v0.4.0

See this forum thread for images and background information.

I ran a test on my Windows virtual machine. The ",,," characters block the yarn rw command from being found, however, this feels like an edge case we might not need to support if the fix isn't obvious.

The space throws the error shown in the image below when running 'yarn rw dev'.

I thought we handled this previously here in the code for the 'dev' command: 🤔

// For Windows: Replaces ` ` with `\ `. Damn, there has got to be a better
// way to sanitize paths?!
const BASE_DIR = getPaths().base.replace(' ', '\\ ')

Screen Shot 2020-04-08 at 9 45 54 PM

@jonniebigodes
Copy link

@thedavidprice as the project is getting traction, it probably wouldn't be a bad idea to start consider trying to implement a solution for special characters like those used in the portuguese language, namely ç, ã,ã, in the spanish language ñ and the also some for the germanic languages like Ü to name a few. Most frameworks/cli tend to stick to ascii characters and tend to overlook it and it comes back to bite them at some point. If this is handled by redwood at boot i'm inclined to believe that it would be a bonus point for redwood.

@thedavidprice
Copy link
Contributor Author

Closed by #457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/confirmed We have confirmed this is a bug topic/cli topic/windows
Projects
None yet
Development

No branches or pull requests

2 participants