Upgrade @apollo/client v3.1.3 #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterp
reviewed
Aug 26, 2020
peterp
reviewed
Aug 26, 2020
peterp
reviewed
Aug 26, 2020
peterp
reviewed
Aug 26, 2020
|
I went through the upgrading guide and it seems like the approach should be to delete all the other packages and only install We would need to modify the imports to match this new world. |
|
@peterp Got it. And thanks for taking a look here! This PR was primarily to get the conversation going. I was curious post Roadmap planning and given this super rough first pass optimistic it won't be too bad. I can take the next pass at the Migration guide. BUT if we end up deleting this PR and opening another, all good. |
Co-authored-by: Peter Pistorius <peter.pistorius@gmail.com>
|
First pass through the Apollo upgrade documentation replacing imports. Generated a new yarn.lock, which I can revert if it causes problems. Passing tests but not working in my project. Seems Also, I noticed |
|
@thedavidprice I think this is good to go now, my only real concern is how to communicate the breaking cache changes: https://www.apollographql.com/docs/react/migrating/apollo-client-3-migration/#breaking-cache-changes Maybe we should merged this, and upgrade the example apps and figure out how bad is it? |
|
@thedavidprice Setting this to "DRAFT" so that we don't accidentally merge it :) |
|
@peterp thanks again for moving this forward! The last item I had on my list is this random bit within Jest config: redwood/packages/core/src/configs/browser/jest.createConfig.ts Lines 28 to 31 in ef48c22
|
|
@thedavidprice Ah, we can remove those. |
|
With Apollo v3: 494 KB |
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-jsx-a11y](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y) | [`6.9.0` -> `6.10.0`](https://renovatebot.com/diffs/npm/eslint-plugin-jsx-a11y/6.9.0/6.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jsx-eslint/eslint-plugin-jsx-a11y (eslint-plugin-jsx-a11y)</summary> ### [`v6.10.0`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/CHANGELOG.md#v6100---2024-09-03) [Compare Source](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/compare/v6.9.0...v6.10.0) ##### Fixed - \[New] `label-has-associated-control`: add additional error message [`#1005`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/1005) - \[Fix] `label-has-associated-control`: ignore undetermined label text [`#966`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/966) ##### Commits - \[Tests] switch from jest to tape [`a284cbf`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/a284cbf4eb21292c4cff87f02be0bfb82764757f) - \[New] add eslint 9 support [`deac4fd`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/deac4fd06eff4c0f5da27611c2a44a009b7e7fda) - \[New] add `attributes` setting [`a1ee7f8`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/a1ee7f8810efafe416eb5d7f6eb0505b52873495) - \[New] allow polymorphic linting to be restricted [`6cd1a70`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/6cd1a7011446e3925f2b49c51ff26246a21491d1) - \[Tests] remove duplicate tests [`74d5dec`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/74d5decb6f2e42c05ce40a45630041fd695a2e7f) - \[Dev Deps] update `@babel/cli`, `@babel/core`, `@babel/eslint-parser`, `@babel/plugin-transform-flow-strip-types` [`6eca235`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/6eca2359f5457af72dbfba265b73297c9232cb3e) - \[readme] remove deprecated travis ci badge; add github actions badge [`0be7ea9`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/0be7ea95f560c6afc6817d381054d914ebd0b2ca) - \[Tests] use `npm audit` instead of `aud` [`05a5e49`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/05a5e4992900e0d5d61e29e13046c90797b68a7c) - \[Deps] update `axobject-query` [`912e98c`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/912e98c425ef9fcc2d7d22b45b4f7e3b445112a5) - \[Deps] unpin `axobject-query` [`75147aa`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/75147aa68888fc150a4efea5b99809969bdc32b2) - \[Deps] update `axe-core` [`27ff7cb`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/27ff7cbf562bf2685fd5a6062e58eb4727cb85c6) - \[readme] fix jsxA11y import name [`ce846e0`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/ce846e00414c41676a6a8601022059878bcc0b89) - \[readme] fix typo in shareable config section in readme [`cca288b`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/cca288b73a39fa0932a57c02a7a88de68fc971fc) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Josh-Walker-GM
pushed a commit
that referenced
this pull request
Sep 10, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [eslint-plugin-jsx-a11y](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y) | [`6.9.0` -> `6.10.0`](https://renovatebot.com/diffs/npm/eslint-plugin-jsx-a11y/6.9.0/6.10.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>jsx-eslint/eslint-plugin-jsx-a11y (eslint-plugin-jsx-a11y)</summary> ### [`v6.10.0`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/blob/HEAD/CHANGELOG.md#v6100---2024-09-03) [Compare Source](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/compare/v6.9.0...v6.10.0) ##### Fixed - \[New] `label-has-associated-control`: add additional error message [`#1005`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/1005) - \[Fix] `label-has-associated-control`: ignore undetermined label text [`#966`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/issues/966) ##### Commits - \[Tests] switch from jest to tape [`a284cbf`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/a284cbf4eb21292c4cff87f02be0bfb82764757f) - \[New] add eslint 9 support [`deac4fd`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/deac4fd06eff4c0f5da27611c2a44a009b7e7fda) - \[New] add `attributes` setting [`a1ee7f8`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/a1ee7f8810efafe416eb5d7f6eb0505b52873495) - \[New] allow polymorphic linting to be restricted [`6cd1a70`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/6cd1a7011446e3925f2b49c51ff26246a21491d1) - \[Tests] remove duplicate tests [`74d5dec`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/74d5decb6f2e42c05ce40a45630041fd695a2e7f) - \[Dev Deps] update `@babel/cli`, `@babel/core`, `@babel/eslint-parser`, `@babel/plugin-transform-flow-strip-types` [`6eca235`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/6eca2359f5457af72dbfba265b73297c9232cb3e) - \[readme] remove deprecated travis ci badge; add github actions badge [`0be7ea9`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/0be7ea95f560c6afc6817d381054d914ebd0b2ca) - \[Tests] use `npm audit` instead of `aud` [`05a5e49`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/05a5e4992900e0d5d61e29e13046c90797b68a7c) - \[Deps] update `axobject-query` [`912e98c`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/912e98c425ef9fcc2d7d22b45b4f7e3b445112a5) - \[Deps] unpin `axobject-query` [`75147aa`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/75147aa68888fc150a4efea5b99809969bdc32b2) - \[Deps] update `axe-core` [`27ff7cb`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/27ff7cbf562bf2685fd5a6062e58eb4727cb85c6) - \[readme] fix jsxA11y import name [`ce846e0`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/ce846e00414c41676a6a8601022059878bcc0b89) - \[readme] fix typo in shareable config section in readme [`cca288b`](https://redirect.github.com/jsx-eslint/eslint-plugin-jsx-a11y/commit/cca288b73a39fa0932a57c02a7a88de68fc971fc) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOltdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm shocked this is passing my local tests and works just fine running my local Redwood Tutorial Blog project. I've only upgraded apollo packages and swapped
apollo-clientfor@apollo/client. It's more likely I’ve missed something and upgraded incorrectly 'cause it's never this easy, right? ¯_(ツ)_/¯Apollo Client v3 Release Notes and breaking changes:
https://github.com/apollographql/apollo-client/releases/tag/v3.0.0
If it's true this upgrade works without issues, it seems we should still tread lightly putting this into a release as it's likely to break projects (especially those relying on apollo caching):
What say you @peterp?
Closes #1002