Hide entry.js | Add setup command to restore #1842
Conversation
dac09
changed the title
dac09
force-pushed
the
feature/hide-entry-js
branch
from
c4a232f
to
a4b04c6
Compare
|
Looking good! 👍 |
|
Thanks for the idea @peterp ! |
dac09
force-pushed
the
feature/hide-entry-js
branch
from
a4b04c6
to
2ab664f
Compare
dac09
changed the title
dac09
added
release:breaking
|
Taking this for an E2E spin now. Specifically double-checking the template codebase changes (for my sanity). |
|
@dac09 CI lint error. Ignore?
|
Yeah must be the new eslint configs that just went in. I'll see if I can selectively ignore these when I update this branch |
There was a problem hiding this comment.
Result of E2E test is a runtime error that's blocking merge:
Looks like you get a Babel ChooseYourOwnAdventure™
Add @babel/preset-react (https://git.io/JfeDR) to the 'presets' section of your Babel config to enable transformation.
If you want to leave it as-is, add @babel/plugin-syntax-jsx (https://git.io/vb4yA) to the 'plugins' section to enable parsing.
|
Can confirm :(. It works ok when building, but not when running |
|
Ok @thedavidprice, e2e tests now pass for me. Sorry about this. Please give it a go on your side! I'm really sad I couldn't use my elegant template solution for the setup command 😭 |
… feature/hide-entry-js * 'feature/hide-entry-js' of github.com:dac09/redwood: Docs: Update CONTRIBUTING.md `rwt link` docs (redwoodjs#1852) Fixes generating scenarios for relations where the field name is different than the relation name (redwoodjs#1848)
What?
Hide's entry.js (the mount point of the web side), and houses it internally within
@redwoodjs/webIf you're a power user 💪🏽, and want to customise it, simply run
yarn rw setup custom-entryand it'll add it back to your project.Help needed 🚩
Note
⚠ This is a breaking change, whether you're opt-ing in to prerender or not.