Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed netlify api config #4247

Merged
merged 3 commits into from Jan 24, 2022

Conversation

memarino92
Copy link
Contributor

@memarino92 memarino92 commented Jan 22, 2022

Closes #4246

@thedavidprice thedavidprice self-assigned this Jan 24, 2022
@thedavidprice
Copy link
Contributor

Looks like the "s" was dropped during the setup deploy code refactor a week ago (#4065).

I scanned config for the other deploy targets, which looked ok. I'll do a more thorough check with I go through deployment QA for the next release.

I'm adding a patch milestone to this — if we don't release on Tuesday, I'll make sure to get this out as a patch instead.

@thedavidprice
Copy link
Contributor

HUGE help with this critical fix @memarino92

Small details = important 🚀

@thedavidprice thedavidprice merged commit bcc41c1 into redwoodjs:main Jan 24, 2022
@jtoar jtoar added this to the next-release milestone Jan 24, 2022
@@ -24,7 +24,7 @@ const notes = [

export const handler = async ({ force }) => {
const tasks = new Listr([
updateApiURLTask('./netlify/function'),
updateApiURLTask('/.netlify/functions'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: verified the directory is .netlify as well ✅

@memarino92 memarino92 deleted the 4246_setup_breaks_app branch January 24, 2022 15:53
dac09 added a commit that referenced this pull request Jan 25, 2022
…s-setup

* 'main' of github.com:redwoodjs/redwood: (87 commits)
  Update scripts tsconfig (#4258)
  Update dependency @types/aws-lambda to v8.10.92 (#4260)
  Update dependency @apollo/client to v3.5.8 (#4262)
  Update dependency msw to v0.36.7 (#4252)
  Update typescript-eslint monorepo to v5.10.1 (#4256)
  Update dependency webpack-cli to v4.9.2 (#4254)
  Update dependency @supabase/supabase-js to v1.29.4 (#4253)
  Update dependency supertokens-auth-react to v0.18.4 (#4255)
  Update dependency ts-morph to v13.0.3 (#4251)
  Update dependency supertokens-auth-react to v0.18.3 (#4248)
  Update dependency esbuild to v0.14.13 (#4249)
  Fixed netlify api config (#4247)
  Add storybook ci option to test that Storybook starts "ok" (#3515)
  Update dependency react-hook-form to v7.25.0 (#4245)
  Update dependency firebase-admin to v10.0.2 (#4244)
  Fix type definitions for pages that take props (#4219)
  update yarn.lock
  v0.42.1
  update yarn.lock
  Pin dependency @types/yargs to v16.0.4 (#4243)
  ...
@jtoar jtoar modified the milestones: next-release, test Jan 27, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.43.0 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Setup netlify deploy command breaks app
4 participants