Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scripts tsconfig #4258

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Update scripts tsconfig #4258

merged 2 commits into from
Jan 25, 2022

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented Jan 24, 2022

Closes #3999. We use babel to transpile scripts on the fly when running them with yarn rw exec, so I don't think these settings will affect anything besides type checking. I've just changed them to match the api and web's tsconfig's. (Not exhaustively, as the paths, typeRoots options, etc wouldn't make sense.)

@jtoar
Copy link
Contributor Author

jtoar commented Jan 24, 2022

@dac09 Could I ask for your review on this?

@jtoar jtoar changed the title Update script tsconfig Update scripts tsconfig Jan 24, 2022
@dac09 dac09 self-requested a review January 25, 2022 07:07
Copy link
Collaborator

@dac09 dac09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think moduleResolution fixes the actual issue, the other ones - not sure if they make any difference

@dac09 dac09 merged commit f4e594d into main Jan 25, 2022
@dac09 dac09 deleted the ds-update-scripts-tsconfig branch January 25, 2022 07:12
@jtoar jtoar added this to the next-release milestone Jan 25, 2022
dac09 added a commit that referenced this pull request Jan 25, 2022
…s-setup

* 'main' of github.com:redwoodjs/redwood: (87 commits)
  Update scripts tsconfig (#4258)
  Update dependency @types/aws-lambda to v8.10.92 (#4260)
  Update dependency @apollo/client to v3.5.8 (#4262)
  Update dependency msw to v0.36.7 (#4252)
  Update typescript-eslint monorepo to v5.10.1 (#4256)
  Update dependency webpack-cli to v4.9.2 (#4254)
  Update dependency @supabase/supabase-js to v1.29.4 (#4253)
  Update dependency supertokens-auth-react to v0.18.4 (#4255)
  Update dependency ts-morph to v13.0.3 (#4251)
  Update dependency supertokens-auth-react to v0.18.3 (#4248)
  Update dependency esbuild to v0.14.13 (#4249)
  Fixed netlify api config (#4247)
  Add storybook ci option to test that Storybook starts "ok" (#3515)
  Update dependency react-hook-form to v7.25.0 (#4245)
  Update dependency firebase-admin to v10.0.2 (#4244)
  Fix type definitions for pages that take props (#4219)
  update yarn.lock
  v0.42.1
  update yarn.lock
  Pin dependency @types/yargs to v16.0.4 (#4243)
  ...
@jtoar jtoar modified the milestones: next-release, test Jan 27, 2022
@thedavidprice thedavidprice modified the milestones: next-release, v0.43.0 Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Archived
Development

Successfully merging this pull request may close these issues.

Old nodejs target used for rw scripts
4 participants