fix(docker): corepack permissions fix and style updates #9976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤣
Any way to add any kind of tests to catch stuff like this in the future? |
Tobbe
approved these changes
Feb 8, 2024
Josh-Walker-GM
approved these changes
Feb 8, 2024
|
@Tobbe yeah I need to get back to CI for docker; we had a repo that was almost there |
jtoar
pushed a commit
that referenced
this pull request
Feb 9, 2024
PRing some fixes @Josh-Walker-GM tipped me off to: - We need to add the `RUN mkdir -p /home/node/.cache` instruction after `RUN mkdir -p /home/node/.yarn/berry/index`. I still can't reliably reproduce this one, but have seen it fail reliably before too for sure and this seems to fix it - I forgot to remove `--load-env-files` when I did the api-server work. It's a no-op now - I forgot to change `API_HOST` to `API_PROXY_TARGET` Adding a few style tweaks while I'm here: - I guess I used `yarn redwood`? This isn't the tutorial - Fixed a typo in the docs
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 9, 2024
…d-cookies-dbauth * 'main' of github.com:redwoodjs/redwood: chore: update rsc fixture (redwoodjs#9986) fix(server): use file extension in import, fix graphql route registering (redwoodjs#9984) chore(deps): update babel monorepo (redwoodjs#9983) fix: unpin react types (redwoodjs#9727) fix(docker): compose dev and prod (redwoodjs#9982) fix(deps): update prisma monorepo to v5.9.1 (redwoodjs#9980) fix(cli): use fetch instead of `yarn npm info` (redwoodjs#9975) fix(test): Update createServer test to use a different port to normal (redwoodjs#9977) fix(docker): corepack permissions fix and style updates (redwoodjs#9976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRing some fixes @Josh-Walker-GM tipped me off to:
RUN mkdir -p /home/node/.cacheinstruction afterRUN mkdir -p /home/node/.yarn/berry/index. I still can't reliably reproduce this one, but have seen it fail reliably before too for sure and this seems to fix it--load-env-fileswhen I did the api-server work. It's a no-op nowAPI_HOSTtoAPI_PROXY_TARGETAdding a few style tweaks while I'm here:
yarn redwood? This isn't the tutorial