-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): use fetch instead of yarn npm info
#9975
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
reviewed
Feb 8, 2024
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Josh-Walker-GM
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed that doing an API request is likely an improvement over spawning a child process.
jtoar
added a commit
that referenced
this pull request
Feb 9, 2024
Some time ago I think I made the call to use `yarn npm info` to get information from NPM about a package's version because I didn't want to install yet another dependency. This was the wrong move in hindsight since it meant 1) spawning a child process and 2) while it seemed safe to assume that Redwood projects would have a version of yarn with the `npm` subcommand, this wasn't true in practice. Now that fetch is in Node.js, we can just use that like @Josh-Walker-GM has elsewhere: https://github.com/redwoodjs/redwood/blob/019361550736f5ed733c37d7f5241583f26d405b/packages/cli/src/commands/experimental/setupDockerHandler.js#L330-L339 I think this might fix the bug you saw when deploying yesterday. --------- Co-authored-by: Dominic Saadi <dominiceliassaadi@gmail.com> Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 9, 2024
…d-cookies-dbauth * 'main' of github.com:redwoodjs/redwood: chore: update rsc fixture (redwoodjs#9986) fix(server): use file extension in import, fix graphql route registering (redwoodjs#9984) chore(deps): update babel monorepo (redwoodjs#9983) fix: unpin react types (redwoodjs#9727) fix(docker): compose dev and prod (redwoodjs#9982) fix(deps): update prisma monorepo to v5.9.1 (redwoodjs#9980) fix(cli): use fetch instead of `yarn npm info` (redwoodjs#9975) fix(test): Update createServer test to use a different port to normal (redwoodjs#9977) fix(docker): corepack permissions fix and style updates (redwoodjs#9976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago I think I made the call to use
yarn npm info
to get information from NPM about a package's version because I didn't want to install yet another dependency. This was the wrong move in hindsight since it meant 1) spawning a child process and 2) while it seemed safe to assume that Redwood projects would have a version of yarn with thenpm
subcommand, this wasn't true in practice.Now that fetch is in Node.js, we can just use that like @Josh-Walker-GM has elsewhere:
redwood/packages/cli/src/commands/experimental/setupDockerHandler.js
Lines 330 to 339 in 0193615
I think this might fix the bug you saw when deploying yesterday.