fix(docker): compose dev and prod #9982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Feb 8, 2024
jtoar
pushed a commit
that referenced
this pull request
Feb 9, 2024
**Problem** By default when once you have run the experimental setup command for docker, the compose setup for dev and prod doesn't quite work. **Changes** 1. We add missing `fs-extra` dependency for the `@redwoodjs/web-server`, it is a runtime dependency. 2. We add a `REDWOOD_API_HOST=0.0.0.0` env var for the dev setup. This is required for the vite dev server to proxy requests correctly. **Notes** @jtoar I'm not overly sure how to test the compose with the updated dependency of the web-server package. Adding the dependency to the web side itself did work so I would imagine this works fine too.
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 9, 2024
…d-cookies-dbauth * 'main' of github.com:redwoodjs/redwood: chore: update rsc fixture (redwoodjs#9986) fix(server): use file extension in import, fix graphql route registering (redwoodjs#9984) chore(deps): update babel monorepo (redwoodjs#9983) fix: unpin react types (redwoodjs#9727) fix(docker): compose dev and prod (redwoodjs#9982) fix(deps): update prisma monorepo to v5.9.1 (redwoodjs#9980) fix(cli): use fetch instead of `yarn npm info` (redwoodjs#9975) fix(test): Update createServer test to use a different port to normal (redwoodjs#9977) fix(docker): corepack permissions fix and style updates (redwoodjs#9976)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
By default when once you have run the experimental setup command for docker, the compose setup for dev and prod doesn't quite work.
Changes
fs-extradependency for the@redwoodjs/web-server, it is a runtime dependency.REDWOOD_API_HOST=0.0.0.0env var for the dev setup. This is required for the vite dev server to proxy requests correctly.Notes
@jtoar I'm not overly sure how to test the compose with the updated dependency of the web-server package. Adding the dependency to the web side itself did work so I would imagine this works fine too.