Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antivirus expiry times get screwed up on some web browsers #17

Open
redxdev opened this issue Sep 14, 2017 · 3 comments
Open

Antivirus expiry times get screwed up on some web browsers #17

redxdev opened this issue Sep 14, 2017 · 3 comments
Labels

Comments

@redxdev
Copy link
Owner

redxdev commented Sep 14, 2017

Not sure why this happens yet. For some reason we need to deal with timezone offsets for antiviruses but not for missions/polls so this doesn't make much sense.

@redxdev redxdev added the bug label Sep 14, 2017
@weinzach
Copy link

Care to explain the issue? Haven't test run the system on our end yet but could try to assist if we can see the problem.

@redxdev
Copy link
Owner Author

redxdev commented Sep 14, 2017

I actually haven't been able to reproduce this myself but other admins for our game have experienced it a number of times.

Missions/polls both have a date input that as of now is handled correctly across all browsers as far as I'm aware. Antiviruses, however, for some reason need their times adjusted when displaying or when sending back to the server (see admin-antivirus-create and admin-antivirus-edit).

What makes this a problem is that some mobile browsers (I haven't confirmed which ones) like to handle their times differently it seems, and the result is that times get messed up if you try to create/edit an antivirus from those browsers.

To test this yourself - create an antivirus and note the exact time you set it to expire. Save it, and check if the time you set is indeed the time that ends up listed on the antivirus list.

@weinzach
Copy link

Yeah no issues found here. I know mobile browsers can handle time differently but since these are being sent via string from a form to the API I see no reason for them to have offset issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants