This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
fix: color related bugs #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix infobox title color not changing.
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 323e95c 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/61272e71c6620400078372e1 😎 Browse the preview: https://deploy-preview-69--reearth-web.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
=======================================
Coverage 57.98% 57.98%
=======================================
Files 42 42
Lines 664 664
Branches 94 94
=======================================
Hits 385 385
Misses 236 236
Partials 43 43 |
rot1024
approved these changes
Aug 26, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* feat: cluster domain models (#69) * Co-authored-by: mimoham24 <mimoham24@users.noreply.github.com> * feat: domain models * add cluster extenstion type * add cluster extension type test case * fix cluster layers * resolve notes * update manifest * fix manifest.yml margin * refactor models * resolve notes * fix manifest file * resolve notes * resolve notes Co-authored-by: HideBa <baba.papa1120.ba@gmail.com> * feat: cluster datalayer (#73) * feat: cluster graphql/mongo (#74) * feat: cluster datalayer * feat: cluster CRUD * resolve notes * resolve notes * add test cases Co-authored-by: HideBa <baba.papa1120.ba@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The color picker wouldn't allow hex input and the infobox's title color wouldn't change when typography's color was changed.
What I've done
Removed troublesome useEffect from color picker to get hex input working.
Add the customColor prop to the infobox's title component so it allowed the chosen color.