This repository has been archived by the owner on Apr 25, 2023. It is now read-only.
feat: Notification system update #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
August 30, 2021 15:37
Move notification code into globalHooks. Remove duplicate code. Update types.
Add transition to notifBanner.
Update project creation notifications. Clean up code.
WIP: Add missing notifications.
Move useEffects into hooks.
Use notifications for errors directly(when possible). Update some text.
Fix gql error handling. Fix where gql errors were overwritten by other notifications.
Add notifications for dataset import. Add better notif handling for archiving projects. Add notif for plugin installation. Add notif for adding assets.
|
✔️ Deploy Preview for reearth-web ready! 🔨 Explore the source changes: 8b527c7 🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/614a9d08209f010007291a59 😎 Browse the preview: https://deploy-preview-73--reearth-web.netlify.app/ |
added 4 commits
September 6, 2021 13:59
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 57.46% 57.67% +0.20%
==========================================
Files 44 46 +2
Lines 703 730 +27
Branches 104 114 +10
==========================================
+ Hits 404 421 +17
- Misses 257 261 +4
- Partials 42 48 +6
|
rot1024
suggested changes
Sep 6, 2021
added 2 commits
September 6, 2021 16:53
Update all imports. Remove notifications README.
rot1024
suggested changes
Sep 7, 2021
added 7 commits
September 7, 2021 17:38
rot1024
suggested changes
Sep 14, 2021
src/components/molecules/EarthEditor/DatasetPane/DatasetModal/hooks.ts
Outdated
Show resolved
Hide resolved
src/components/molecules/EarthEditor/DatasetPane/DatasetModal/hooks.ts
Outdated
Show resolved
Hide resolved
src/components/molecules/EarthEditor/DatasetPane/DatasetModal/hooks.ts
Outdated
Show resolved
Hide resolved
added 8 commits
September 14, 2021 18:02
Add useError for apollo error special case
rot1024
previously approved these changes
Sep 15, 2021
Co-authored-by: rot1024 <aayhrot@gmail.com>
added 3 commits
September 16, 2021 11:34
HideBa
reviewed
Sep 17, 2021
rot1024
approved these changes
Sep 22, 2021
keiya01
pushed a commit
that referenced
this pull request
Apr 25, 2023
* feat: cluster domain models (#69) * Co-authored-by: mimoham24 <mimoham24@users.noreply.github.com> * feat: domain models * add cluster extenstion type * add cluster extension type test case * fix cluster layers * resolve notes * update manifest * fix manifest.yml margin * refactor models * resolve notes * fix manifest file * resolve notes * resolve notes Co-authored-by: HideBa <baba.papa1120.ba@gmail.com> * feat: cluster datalayer (#73) * feat: cluster graphql/mongo (#74) * feat: cluster datalayer * feat: cluster CRUD * resolve notes * resolve notes * add test cases Co-authored-by: HideBa <baba.papa1120.ba@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This is an update to the notification system. We were creating notifications in a couple different ways and had duplicate code, so this cleans things up and is trying to make things simpler.
What I've done
What I haven't done
How I tested
Screenshot
Which point I want you to review particularly
test cases
Dashboard
Settings
Earth Editor