Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

feat: support dataset schema preview and create layer group from selected primitive type #74

Merged
merged 45 commits into from Nov 12, 2021

Conversation

HideBa
Copy link
Member

@HideBa HideBa commented Sep 7, 2021

Overview

  • Refined dataset import which allows users to preview datasets and can create layer groups with other types of primitives.

What I've done

  • Add table component
  • Add query to fetch dataset, dataset fields
  • Add mutation to create layer group from dataset schema with the selected primitive type(e.g. marker, sphere, photo overlay, etc)
  • Refactored property group component
  • Removed Drag & Drop of dataset schema cell since it won't be used anymore
  • Added gql fragments(dataset, plugins)

What I haven't done

  • Dataset update feature. Since Google spreadsheet integration has an error and we can't test it all I opened this PR first and later I'll make another PR that allows us to update the dataset.
  • The feature which allows users to select which field will be used for layer's title

How I tested

  • I've tested a couple of dataset schemas if I can see the preview of that
  • I've tested all types of primitives if I can create layer group from the dataset schema

Screenshot

スクリーンショット 2021-11-09 20 43 58スクリーンショット 2021-11-09 20 44 40
スクリーンショット 2021-11-09 20 44 32
スクリーンショット 2021-11-09 20 44 12
review particularly

Memo

@netlify
Copy link

netlify bot commented Sep 7, 2021

✔️ Deploy Preview for reearth-web ready!

🔨 Explore the source changes: 55c0462

🔍 Inspect the deploy log: https://app.netlify.com/sites/reearth-web/deploys/618ddfde593d590007814282

😎 Browse the preview: https://deploy-preview-74--reearth-web.netlify.app

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #74 (55c0462) into main (b72f17a) will decrease coverage by 0.12%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   44.54%   44.42%   -0.13%     
==========================================
  Files          56       56              
  Lines        1109     1121      +12     
  Branches      179      179              
==========================================
+ Hits          494      498       +4     
- Misses        562      570       +8     
  Partials       53       53              
Impacted Files Coverage Δ
src/state/index.ts 77.41% <ø> (ø)
src/gql/graphql-client-api.tsx 36.74% <33.33%> (-0.13%) ⬇️

@HideBa HideBa marked this pull request as ready for review November 11, 2021 09:10
Copy link
Contributor

@issmail-basel issmail-basel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job seems fine nothing critical
I will double check for comments if found

Copy link
Member

@lavalse lavalse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have test the basic function, works good for me

Copy link
Member

@rot1024 rot1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is ok

  • Resolve conflicts
  • Change the PR title so everyone can know more details in CHANGELOG

@HideBa HideBa changed the title feat: refine dataset import feat: support dataset schema preview and create layer group from selected primitive type Nov 12, 2021
@HideBa HideBa merged commit 769b866 into main Nov 12, 2021
@HideBa HideBa deleted the refine-dataset-import branch November 12, 2021 03:51
keiya01 pushed a commit that referenced this pull request Apr 25, 2023
* feat: cluster domain models (#69)

* Co-authored-by: mimoham24 <mimoham24@users.noreply.github.com>

* feat: domain models

* add cluster extenstion type

* add cluster extension type test case

* fix cluster layers

* resolve notes

* update manifest

* fix manifest.yml margin

* refactor models

* resolve notes

* fix manifest file

* resolve notes

* resolve notes

Co-authored-by: HideBa <baba.papa1120.ba@gmail.com>

* feat: cluster datalayer (#73)

* feat: cluster graphql/mongo (#74)

* feat: cluster datalayer

* feat: cluster CRUD

* resolve notes

* resolve notes

* add test cases

Co-authored-by: HideBa <baba.papa1120.ba@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants