Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(web): collapse side panels #799

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Nov 8, 2023

Overview

Make sure side panels are collapse at first render
image

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner November 8, 2023 08:52
Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit c4fe516
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/654b4c6988cbc70008639104
😎 Deploy Preview https://deploy-preview-799--reearth-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot requested a review from pyshx November 8, 2023 08:53
@github-actions github-actions bot added the web label Nov 8, 2023
@nina992 nina992 changed the title Chorecollaps scene side panel Chore: collapse side panels Nov 8, 2023
@nina992 nina992 changed the title Chore: collapse side panels Chore : collapse side panels Nov 8, 2023
@nina992 nina992 changed the title Chore : collapse side panels chore : collapse side panels Nov 8, 2023
@nina992 nina992 changed the title chore : collapse side panels chore(web): collapse side panels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #799 (c4fe516) into main (9c4c84a) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #799      +/-   ##
==========================================
- Coverage   25.81%   25.81%   -0.01%     
==========================================
  Files        1636     1636              
  Lines      179304   179304              
  Branches     3920     3919       -1     
==========================================
- Hits        46289    46288       -1     
- Misses     131926   131927       +1     
  Partials     1089     1089              
Flag Coverage Δ
web 24.05% <0.00%> (-0.01%) ⬇️
web-beta 24.05% <0.00%> (-0.01%) ⬇️
web-classic 24.05% <0.00%> (-0.01%) ⬇️
web-utils 24.05% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...res/Editor/tabs/map/LeftPanel/GroupField/index.tsx 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

@nina992 nina992 merged commit 8aa78f7 into main Nov 8, 2023
17 of 22 checks passed
@nina992 nina992 deleted the chore/collaps-scene-sidePanel branch November 8, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants