Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for manufacturerSpecificData (Android) and kCBAdvDataManufacturerData (iOS) #59

Closed
etwilliams opened this issue Oct 16, 2020 · 1 comment
Closed

Add support for manufacturerSpecificData (Android) and kCBAdvDataManufacturerData (iOS) #59

etwilliams opened this issue Oct 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@etwilliams
Copy link

I've been looking into the library for use in my companies BLE apps. It seems very simple to use and I look forward to being able to add this to our toolkit. One feature we use a lot is embedding information into the advertising data. Is it possible to add ScanRecord.manufacturerSpecificData (for Android) and kCBAdvDataManufacturerData (for iOS) into the BluetoothPeripheral class? I'm an Android developer and could help with that side.
@Reedyuk
Copy link
Owner

Reedyuk commented Oct 16, 2020

Nice idea, happy for you to put in a PR for this.

@Reedyuk Reedyuk self-assigned this Oct 24, 2020
@nbransby nbransby self-assigned this Nov 16, 2020
@Reedyuk Reedyuk added the enhancement New feature or request label Apr 7, 2022
@Reedyuk Reedyuk removed their assignment Apr 7, 2022
@Reedyuk Reedyuk closed this as completed Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nbransby @Reedyuk @etwilliams