Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mark all as read" button should clear extension's unread notifications #291

Closed
vadimdemedes opened this issue Sep 4, 2016 · 5 comments
Closed
Labels

Comments

@vadimdemedes
Copy link

vadimdemedes commented Sep 4, 2016

"Mark all as read" button does not clear notifications, that were "remembered" by the extension's "Mark as unread" feature.

screen shot 2016-09-04 at 7 22 57 pm

See #284 for "mark as unread" feature.

@AshikNesin
Copy link
Contributor

I'm working on it :)

@jgierer12
Copy link
Contributor

jgierer12 commented May 14, 2017

@AshikNesin can you still reproduce this? For me, local notifications get cleared along with GitHub's native ones

@AshikNesin
Copy link
Contributor

@jgierer12 Just checked. The bug still exists.

screen recording 2017-05-14 at 08 57 pm

@jgierer12
Copy link
Contributor

My bad, I thought @vadimdemedes was talking about the checkmark button in the per-repo header

@AshikNesin
Copy link
Contributor

@jgierer12 No problem 😄

Have fixed it 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants