Mccalluc/delete tmp dirs on purge #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
not the behavior I saw locally, but even apart from that, I'm doing things in the wrong order: should not delete directory while the container that depends on it is still running. |
Mock test not working, and after a bit decided not worth the effort.
…d be using them by accident at some point.
|
@scottx611x : Tests pass locally. Started off just cleaning up the temp dir, and then continued into making the temp dir configurable. If this passes, I'll tag it, and work on a separate PR in refinery proper. |
|
Failure is related to tag mismatch, but I don't really understand it. I would merge and then release a new tag if necessary. |
scottx611x
approved these changes
Sep 20, 2017
| @@ -195,6 +193,7 @@ def test_purge(self): | |||
| )) | |||
| self.assertEqual(1, self.count_containers()) | |||
| self.assert_loads_eventually(url, 'Welcome to nginx!') | |||
| self.assertGreater(self.ls_tmp(), ls_tmp_orig) | |||
There was a problem hiding this comment.
ls_tmp_orig -> self.initial_tmp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards refinery-platform/refinery-platform#2160 (Will need to pin the version here and update the dependency there.)
Fix #68, Fix #67 (I think)
fix #61