Add index file for bam visualizations #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mccalluc
approved these changes
Oct 28, 2019
context/on_startup.py
Outdated
| ), | ||
| "url": node_data["file_url"] | ||
| } | ||
| if '.bam' == os.path.splitext(track['name']): |
There was a problem hiding this comment.
Suggested change
| if '.bam' == os.path.splitext(track['name']): | |
| if '.bam' == os.path.splitext(node_data["file_url"]): |
Probably safer to go to the source for this: The track['name'] is really just a human readable string, and the format could change.
(If you do accept this, maybe define a variable for node_data["file_url"], since it's being used three times.)
context/on_startup.py
Outdated
Comment on lines
41
to
42
| # assume that there is only one auxiliary file for bam igv and it's | ||
| # the .bai file |
There was a problem hiding this comment.
Suggested change
| # assume that there is only one auxiliary file for bam igv and it's | |
| # the .bai file | |
| # Assume that there is only one auxiliary file for bam igv and it's the .bai file. |
I generally prefer to have a capital letter and period, when a comment is a sentence, but your call.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By fixing refinery-platform/refinery-platform#2718 and updating the API, all we need to do here is add the indexURL for bam files. We should probably hold off on merging this until after the next release (i.e after Monday/Tuesday). No reason we can't review it though!