Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove REFINERY_USER_AUTHENTICATED if unused #1765

Closed
mccalluc opened this issue Jun 5, 2017 · 3 comments
Closed

Remove REFINERY_USER_AUTHENTICATED if unused #1765

mccalluc opened this issue Jun 5, 2017 · 3 comments
Assignees
@mccalluc
Labels
client security technical debt ui
Projects
Technical Debt
Milestone
Release 1.6.1

Comments

@mccalluc
Copy link
Member

mccalluc commented Jun 5, 2017 •
edited

refinery/templates/core/user_files.html :

    {% if user.is_authenticated %}
      var REFINERY_USER_AUTHENTICATED = true;
    {% else %}
      var REFINERY_USER_AUTHENTICATED = false;

The main problem would be if any kind of security relied on this...
@mccalluc mccalluc self-assigned this Jun 5, 2017
@mccalluc
Copy link
Member Author

mccalluc commented Jun 5, 2017 

function updateDownloadButton(button_id) {
          if (query.getCurrentDocumentCount() > MAX_DOWNLOAD_FILES || query.getCurrentDocumentCount() <= 0 || !REFINERY_USER_AUTHENTICATED || ( showAnnotation && !allowAnnotationDownload )) {

I think this is just used to determine if a button should be shown. I also suspect that this button might not any longer be part of Refinery? I'm going to CC Scott, who was interested in looking at it a little closer, but I'll go ahead and close.

@mccalluc mccalluc closed this as completed Jun 5, 2017
@mccalluc
Copy link
Member Author

mccalluc commented Jun 5, 2017

cc @scottx611x

@mccalluc mccalluc mentioned this issue Jun 5, 2017
Merged
@hackdna hackdna added this to the Release 1.5.7 milestone Jun 5, 2017
@hackdna
Copy link
Member

hackdna commented Jun 5, 2017

We should remove this variable if no longer used. Re-opening as a technical debt issue.

@hackdna hackdna reopened this Jun 5, 2017
@hackdna hackdna changed the title In JS, what is REFINERY_USER_AUTHENTICATED used for? Remove REFINERY_USER_AUTHENTICATED if unused Jun 5, 2017
@ngehlenborg ngehlenborg modified the milestones: Next, Release 1.6.1 Oct 17, 2017
@scottx611x scottx611x added this to Code in Technical Debt Oct 20, 2017
mccalluc added a commit that referenced this issue Oct 27, 2017
@mccalluc
Remove unused JS global. Fix #1765.
b86aa43
mccalluc added a commit that referenced this issue Oct 30, 2017
@mccalluc
Remove unused JS global. Fix #1765. (#2287)
6f26c1d
jkmarx added a commit that referenced this issue Nov 1, 2017
@jkmarx
Jkmarx/remove old node maps api (#2279)
4f055bf 
* Remove node relationship model and references.

* Remove node_set model and references.

* Bump version (#2264)

* Bump version

* Change name to match expectations of on_startup.py

* Update tests to work with new IGV image version

* Update assertion with new Solr mock info

* Assert that `VisualizationError` is raised now that `launch()` is being called directly

* Scottx611x/set workflow tool analysis library_id (#2280)

* Set Analysis.library_id

* Test that WorkflowTool.analysis.library_id is set when we create a Galaxy Library

* Jkmarx/analysis tab url fix (#2276)

* Add facet name.

* Remove error caused from double encoding.

* Refactor facet_name method.

* Update test.

* Remove data_set_query which is not needed.

* Update analysis complete url.

* Update urls to all analysis links.

* Remove consoles.

* Remove self targets, unneccessary.

* Fix typo in `generate_tool_definitions` mgmt command (#2270)

* Mock USER_FILES_COLUMNS (#2282)

Tests pass locally. Fix #2235.

* Remove unused JS global. Fix #1765. (#2283)

* Scottx611x/tool manager test coverage (#2271)

* Add test for case where specified docker image has no version

* Add test coverage for `FileTypeValidationErrors`

* Add test coverage for ToolDefinitions with bad filetypes specified

* Add test coverage for `get_workflows()`

* `get_queryset()` shouldn't return an HTTPResponse;
The exception handling here also might mask the importance of the GuardianError.
Letting it propgate might not be a bad idea since this is one of those "shouldn't happen" scenarios, and knowing that something is wrong asap would be great.

* Fix typos

* Remove comma

* Be more clear as to my intentions with the overriding of this setting

* Factor out commonalities between these tests

* Fix test

* Remove unused JS global. Fix #1765. (#2287)

* Remove extra scrollbar cause by auto class on exterior panel. (#2297)

* Mccalluc/misc travis log cleanup (#2302)

* geckodriver download progress can be 1000 lines in the log

* FF download also wastes space... but what does the unzip?

* Remove "PhantomJS 2.1.1 (Linux 0.0.0): Executed 638 of 648 SUCCESS" messages

* Last commit was in entirely the wrong place to quiet the JS tests
(There should be a better way to make them quiet, but it looks like we choose between this, or a new package like mostly-quiet-grunt

* Adding grep also confuses the result status

* Feels like there should be a better way, but this cleans up the output without confusing the status (#2303)

* Jkmarx/data set 1 cleanup (#2278)

* Remove analysis-launch module.

* Remove from unit test.

* Remove node-relationship module.

* Remove node-mapping module and add third party dependency to refinery.js.

* Clean up data-set-nav and remove references.

* Update unit tests.

* Remove select workflow module.

* Remove igv module.

* Fix typo ,

* Remove solr_table_view.

* Remove analysis view.

* Remove solr_facet view.

* Remove pivot matrix.

* Remove data_set_configurator.

* Remove IGV references.

* Remove the file browser one table and some unneccessary code.

* Remove unneeded code since there's only one view.

* Remove float thread code.

* Remove float thread dependencies.

* Remove matrix styling.

* Remove old help modals, not dealing with provvis.

* Remove tipsy.

* Remove tipsy depenency in angular.

* Remove commented code which references old node sets.

* Remove node_set_manager reference.

* Remove node-set-manager references.

* Remove lingering merge tag.

* Add node set comments.

* Fix comment typo.

* Remove added dependency in wrong location and tracked.

* Fix height error.

* Revert data_set.html.

* Jkmarx/provvis tab integration (#2289)

* Add provvis tab.

* Seperate out provvis module initialization.

* Move ctrls to own file.

* Move directives to own files.

* Remove inialization module, ctrl, & directives to own file.

* Add provvis module.

* Fix page redirect.

* Fix info-panel routing.

* Fix bug with panel groups redirect.

* Better solution to nav tab.

* Add padding to top of infobar.

* Add refinery-base class to btns.

* Remove modal for popover.

* Remove provenance view and template.

* Cosemetic changes.

* Prevent pre-generation from content.js when loading in data-set page.

* Add bootbox.

* Fix height issue.

* Fix missing closed tag.

* Fix outdent.

* Fix tabbing.
@scottx611x scottx611x moved this from Code to Done in Technical Debt Nov 6, 2017
@hackdna hackdna added this to ToDo in Security Apr 18, 2019
@hackdna hackdna removed this from ToDo in Security Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mccalluc mccalluc

Labels
client security technical debt ui
Projects
Technical Debt
  
Done
Milestone
Release 1.6.1
Development

No branches or pull requests
4 participants
@hackdna @mccalluc @ngehlenborg @scottx611x