Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove igv & higlass Selenium tests in favor of a lightweight example #2238

Closed
4 tasks done
scottx611x opened this issue Oct 16, 2017 · 0 comments
Closed
4 tasks done

Comments

@scottx611x
Copy link
Member

scottx611x commented Oct 16, 2017

There already exist tests in https://github.com/refinery-platform/docker_igv_js & https://github.com/scottx611x/refinery-higlass-docker That assert that mock Refinery data can be ingested/handled. Its probably overkill/redundant to have these same tests in Refinery.

After talking with @mccalluc I'm going to make a hello-world docker image that simply displays all data (file urls, parameters, etc.) that Refinery sends over and write non-selenium tests against that.

This image would also be really helpful to prospective VisTool developers who want to see what info they can get out of the system.

@scottx611x scottx611x self-assigned this Oct 16, 2017
@ngehlenborg ngehlenborg modified the milestone: Release 1.6.1 Oct 17, 2017
@scottx611x scottx611x added this to the Next milestone Feb 22, 2018
scottx611x added a commit that referenced this issue Mar 1, 2018
* Add VisualizationToolProxy so that we can check user perms. & provide persistant VisTool urls

* Add `user_has_access_to_tool()`

* Fix reference

* Add test coverage

* Fix typo

* Rename VizualizationProxy to AutoRelaunchProxy

* Simplify logic

* Less wordy error messages

* Fix test

* Just assert that we can launch Igv;
Towards #2238 and refinery-platform/visualization-tools#22
@scottx611x scottx611x modified the milestones: Next, Release 1.6.4 Mar 20, 2018
@jkmarx jkmarx modified the milestones: Release 1.6.4, Next May 11, 2018
@jkmarx jkmarx removed this from the Next milestone Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants